Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QCDLoop Fortran #29014

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Add QCDLoop Fortran #29014

merged 1 commit into from
Feb 4, 2025

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 3, 2025 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [N/A] If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
    • Package only provides a static library but CFEP is followed.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@matthewfeickert
Copy link
Member Author

@chrisburr We already have the C++ version as qcdloop (https://github.com/conda-forge/qcdloop-feedstock). Would you suggest qcdloop-fortran or just ql (the library name)?

@matthewfeickert matthewfeickert force-pushed the feat/add-qcdloop-fortran branch from 0aef66a to f67fa0e Compare February 3, 2025 20:42
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 3, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/qcdloop-fortran/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/qcdloop-fortran/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13130159937. Examine the logs at this URL for more detail.

@chrisburr
Copy link
Member

Would you suggest qcdloop-fortran or just ql (the library name)?

I would say qcdloop-fortran. I think it's a bit too niche to justify a two character package name.

@matthewfeickert matthewfeickert marked this pull request as ready for review February 3, 2025 21:59
@matthewfeickert
Copy link
Member Author

@conda-forge/staged-recipes, ready for review! This is a fortran recipe.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@matthewfeickert
Add QCDLoop Fortran
82800b5 
* Add QCDLoop v1.98 in Fortran.
   - c.f. https://qcdloop.fnal.gov/
* Permission to license QCDLoop as MIT (previously unlicensed) was given by
  author R. Keith Ellis via email on 2025-02-03.
@matthewfeickert matthewfeickert force-pushed the feat/add-qcdloop-fortran branch from f67fa0e to 82800b5 Compare February 4, 2025 07:09
@chrisburr chrisburr merged commit b82db33 into conda-forge:main Feb 4, 2025
7 checks passed
@matthewfeickert matthewfeickert deleted the feat/add-qcdloop-fortran branch February 4, 2025 07:29
@matthewfeickert
Copy link
Member Author

Thanks @chrisburr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisburr chrisburr chrisburr approved these changes

Assignees
No one assigned
Labels
review-requested staged-recipes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewfeickert @conda-forge-admin @chrisburr